[webkit-reviews] review granted: [Bug 222935] [LayoutTests] Convert http/tests/cache convert PHP to Python : [Attachment 424949] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 1 15:39:08 PDT 2021


Jonathan Bedard <jbedard at apple.com> has granted Chris Gambrell
<cgambrell at apple.com>'s request for review:
Bug 222935: [LayoutTests] Convert http/tests/cache convert PHP to Python
https://bugs.webkit.org/show_bug.cgi?id=222935

Attachment 424949: Patch

https://bugs.webkit.org/attachment.cgi?id=424949&action=review




--- Comment #24 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 424949
  --> https://bugs.webkit.org/attachment.cgi?id=424949
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424949&action=review

> LayoutTests/http/tests/cache/resources/x-frame-options.py:15
> +one_year = 12 * 31 * 24 * 60 * 60

Super weird way to represent a year, we usually use 365 instead of 12 * 31


More information about the webkit-reviews mailing list