[webkit-reviews] review granted: [Bug 224038] Fix some missing exception checks in HTMLMediaElement methods. : [Attachment 424870] proposed patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 1 07:37:37 PDT 2021
Eric Carlson <eric.carlson at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 224038: Fix some missing exception checks in HTMLMediaElement methods.
https://bugs.webkit.org/show_bug.cgi?id=224038
Attachment 424870: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=424870&action=review
--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 424870
--> https://bugs.webkit.org/attachment.cgi?id=424870
proposed patch.
View in context: https://bugs.webkit.org/attachment.cgi?id=424870&action=review
> Source/WebCore/html/HTMLMediaElement.cpp:7277
> + auto clearExceptionAndReturnFalse = [&] () -> bool {
> + scope.clearException();
> + return false;
> + };
I think we might as well report the exception unless you know of a reason not
to. Failing setup here will change the page behavior, so logging something may
help us diagnose user problems.
More information about the webkit-reviews
mailing list