[webkit-reviews] review granted: [Bug 224044] Cleanup shouldComputeLogicalWidthFromAspectRatio and shouldComputeLogicalWidthFromAspectRatioAndInsets : [Attachment 424886] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 224044: Cleanup shouldComputeLogicalWidthFromAspectRatio and
shouldComputeLogicalWidthFromAspectRatioAndInsets
https://bugs.webkit.org/show_bug.cgi?id=224044

Attachment 424886: Patch

https://bugs.webkit.org/attachment.cgi?id=424886&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 424886
  --> https://bugs.webkit.org/attachment.cgi?id=424886
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424886&action=review

> Source/WebCore/rendering/RenderBox.cpp:5130
> +    return style().width().isAuto() && style().height().isAuto() &&
!style().logicalTop().isAuto() && !style().logicalBottom().isAuto() &&
(style().logicalLeft().isAuto() || style().logicalRight().isAuto());

I'd probably split this into multiple returns.