[webkit-reviews] review granted: [Bug 217150] [JSC] We should not tag C function with JIT code related ptr tag : [Attachment 410170] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 217150: [JSC] We should not tag C function with JIT code related ptr tag
https://bugs.webkit.org/show_bug.cgi?id=217150

Attachment 410170: Patch

https://bugs.webkit.org/attachment.cgi?id=410170&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 410170
  --> https://bugs.webkit.org/attachment.cgi?id=410170
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410170&action=review

r=me with fixes.

> Source/JavaScriptCore/jit/JITOperations.cpp:1227
> +	       DisallowGC disallowGC;

Why disallowGC here?  I don't think we should be disallowing GC for the entire
duration of the time we're executing the native function.  Please remove this.

> Source/JavaScriptCore/jit/JITOperations.cpp:1255
> +	   DisallowGC disallowGC;

Ditto.	Please remove.

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1673
> +	       DisallowGC disallowGC;

Ditto.	Please remove.

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1692
> +	   DisallowGC disallowGC;

Ditto.	Please remove.

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1963
> +    DisallowGC disallowGC;

Ditto.	Please remove.

> Source/JavaScriptCore/llint/LLIntThunks.cpp:190
>  #endif

nit: can you add `// ENABLE(JIT)` after this #endif to make it clearer what
section it terminates?