[webkit-reviews] review denied: [Bug 171589] update FormData to latest spec webidl : [Attachment 410131] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 30 12:28:45 PDT 2020


Chris Dumez <cdumez at apple.com> has denied Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 171589: update FormData to latest spec webidl
https://bugs.webkit.org/show_bug.cgi?id=171589

Attachment 410131: Patch

https://bugs.webkit.org/attachment.cgi?id=410131&action=review




--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 410131
  --> https://bugs.webkit.org/attachment.cgi?id=410131
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410131&action=review

> Source/WebCore/html/DOMFormData.idl:40
> +    // FIXME: should be optional HTMLFormElement.

I think we should make this work. This change makes our IDL look worse.
I am actually very surprised it does not work.


More information about the webkit-reviews mailing list