[webkit-reviews] review granted: [Bug 217077] Storage Access API: Enable per-page storage access scope and align test cases : [Attachment 409955] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 217077: Storage Access API: Enable per-page storage access scope and align
test cases
https://bugs.webkit.org/show_bug.cgi?id=217077

Attachment 409955: Patch

https://bugs.webkit.org/attachment.cgi?id=409955&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 409955
  --> https://bugs.webkit.org/attachment.cgi?id=409955
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409955&action=review

> Source/WebCore/ChangeLog:21
> +	       Changed the default setting for m_storageAccessScope.

"to per-page."

> Source/WebCore/page/Settings.yaml:705
> +  initial: true

Does this setting only exist to support test cases? I wonder if we should have
some place to collect these kinds of settings (not relevant to this patch
today, just an idea).