[webkit-reviews] review granted: [Bug 198912] [iOS] MediaRecorder incorrect screen orientation handling : [Attachment 410099] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 30 08:10:31 PDT 2020


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 198912: [iOS] MediaRecorder incorrect screen orientation handling
https://bugs.webkit.org/show_bug.cgi?id=198912

Attachment 410099: Patch

https://bugs.webkit.org/attachment.cgi?id=410099&action=review




--- Comment #16 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 410099
  --> https://bugs.webkit.org/attachment.cgi?id=410099
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410099&action=review

>
Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
433
> +	       m_videoTransform = CGAffineTransformScale(*m_videoTransform, -1,
1);

Do we always want to flip the transform?


More information about the webkit-reviews mailing list