[webkit-reviews] review granted: [Bug 217123] [GTK] Chassis type check fails if the value is quoted : [Attachment 410108] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 30 06:07:15 PDT 2020


Carlos Garcia Campos <cgarcia at igalia.com> has granted Alexander Mikhaylenko
<alexm at gnome.org>'s request for review:
Bug 217123: [GTK] Chassis type check fails if the value is quoted
https://bugs.webkit.org/show_bug.cgi?id=217123

Attachment 410108: Patch

https://bugs.webkit.org/attachment.cgi?id=410108&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 410108
  --> https://bugs.webkit.org/attachment.cgi?id=410108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410108&action=review

> Source/WTF/wtf/glib/ChassisType.cpp:51
> +	       if (error.get() != nullptr)

Do not compare to nullptr, and you don't need the .get() either:

if (error)
    g_warning();


More information about the webkit-reviews mailing list