[webkit-reviews] review granted: [Bug 206767] [css-flexbox] Implement row-gap and column-gap for flex layout : [Attachment 410109] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 206767: [css-flexbox] Implement row-gap and column-gap for flex layout
https://bugs.webkit.org/show_bug.cgi?id=206767

Attachment 410109: Patch

https://bugs.webkit.org/attachment.cgi?id=410109&action=review




--- Comment #13 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 410109
  --> https://bugs.webkit.org/attachment.cgi?id=410109
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410109&action=review

r=me, please wait for green EWSs before landing

> Source/WebCore/rendering/FlexibleBoxAlgorithm.cpp:78
> +    if (!lineItems.isEmpty()) {

Maybe you can add "m_gapBetweenItems > 0" too, otherwise you don't need to do
anything.