[webkit-reviews] review granted: [Bug 217088] Re-align DocumentAndElementEventHandlers.idl, GlobalEventHandlers.idl and WindowEventHandlers.idl with the HTML spec : [Attachment 410080] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 29 18:53:05 PDT 2020


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 217088: Re-align DocumentAndElementEventHandlers.idl,
GlobalEventHandlers.idl and WindowEventHandlers.idl with the HTML spec
https://bugs.webkit.org/show_bug.cgi?id=217088

Attachment 410080: Patch

https://bugs.webkit.org/attachment.cgi?id=410080&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 410080
  --> https://bugs.webkit.org/attachment.cgi?id=410080
Patch

Seems like you could have added more of these and not left them commented out.
Typically they do no harm if they are simply listening to events we don’t
dispatch, as long as they are not somehow used for feature detection.


More information about the webkit-reviews mailing list