[webkit-reviews] review granted: [Bug 217107] Fix EXT_color_buffer_half_float on iOS : [Attachment 410058] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 29 15:48:20 PDT 2020


Kenneth Russell <kbr at google.com> has granted James Darpinian
<jdarpinian at chromium.org>'s request for review:
Bug 217107: Fix EXT_color_buffer_half_float on iOS
https://bugs.webkit.org/show_bug.cgi?id=217107

Attachment 410058: Patch

https://bugs.webkit.org/attachment.cgi?id=410058&action=review




--- Comment #4 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 410058
  --> https://bugs.webkit.org/attachment.cgi?id=410058
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410058&action=review

Looks good; one small question. r+

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp:296
> +	       functions->hasExtension("GL_EXT_color_buffer_half_float"))

Should this be "hasGLESExtension" (here and upstream)?


More information about the webkit-reviews mailing list