[webkit-reviews] review granted: [Bug 217028] Refactor test runner code to cut down on copy/paste code and long-winded repetitive idioms : [Attachment 409952] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 217028: Refactor test runner code to cut down on copy/paste code and
long-winded repetitive idioms
https://bugs.webkit.org/show_bug.cgi?id=217028

Attachment 409952: Patch

https://bugs.webkit.org/attachment.cgi?id=409952&action=review




--- Comment #16 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 409952
  --> https://bugs.webkit.org/attachment.cgi?id=409952
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409952&action=review

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:96
> +static JSContextRef mainJSContext()

I would prefer this be called mainFrameJSContext, just because main on its own
is so ambiguous, but I feel this in a very minor way.