[webkit-reviews] review granted: [Bug 217026] [GPU Process] Several layout tests in fast/canvas crash under GraphicsContext::clipToImageBuffer : [Attachment 409966] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 217026: [GPU Process] Several layout tests in fast/canvas crash under
GraphicsContext::clipToImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=217026

Attachment 409966: Patch

https://bugs.webkit.org/attachment.cgi?id=409966&action=review




--- Comment #12 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 409966
  --> https://bugs.webkit.org/attachment.cgi?id=409966
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409966&action=review

> Source/WebCore/platform/graphics/GraphicsContext.h:414
> +    ClipToDrawingCommandsResult clipToDrawingCommands(const FloatRect&
destination, ColorSpace, Function<void(GraphicsContext&)>&&);

This is great. We might end up generalizing this for other image buffer code
paths, but it's a good start.