[webkit-reviews] review granted: [Bug 207634] [GStreamer] Internal audio rendering support : [Attachment 409843] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 207634: [GStreamer] Internal audio rendering support
https://bugs.webkit.org/show_bug.cgi?id=207634

Attachment 409843: Patch

https://bugs.webkit.org/attachment.cgi?id=409843&action=review




--- Comment #34 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 409843
  --> https://bugs.webkit.org/attachment.cgi?id=409843
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409843&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitAudioSinkGStreamer.cpp:186
> +    if (value && equalIgnoringASCIICase(value, "1")) {

Nit: You probably don't need to ignore case here.