[webkit-reviews] review granted: [Bug 217059] Add stubs for AudioWorklet : [Attachment 409953] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 217059: Add stubs for AudioWorklet
https://bugs.webkit.org/show_bug.cgi?id=217059

Attachment 409953: Patch

https://bugs.webkit.org/attachment.cgi?id=409953&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 409953
  --> https://bugs.webkit.org/attachment.cgi?id=409953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409953&action=review

> Source/WebCore/css/DOMCSSPaintWorklet.cpp:76
> +void PaintWorklet::addModule(Document& document, const String& moduleURL,
WorkletOptions&&, DOMPromiseDeferred<void>&& promise)
> +{
> +    // FIXME: We should download the source from the URL
> +    // https://bugs.webkit.org/show_bug.cgi?id=191136
> +    auto maybeContext = PaintWorkletGlobalScope::tryCreate(document,
ScriptSourceCode(moduleURL));
> +    if (UNLIKELY(!maybeContext)) {
> +	   promise.reject(Exception { OutOfMemoryError });
> +	   return;
> +    }
> +    auto context = maybeContext.releaseNonNull();
> +    context->evaluate();
> +
> +    auto locker = holdLock(context->paintDefinitionLock());
> +    for (auto& name : context->paintDefinitionMap().keys())
> +	   document.setPaintWorkletGlobalScopeForName(name,
makeRef(context.get()));
> +    promise.resolve();
> +}
> +

Did you mean to include PaintWorklet changes in this patch?