[webkit-reviews] review granted: [Bug 217055] Add Bounds Check Elimination validation for debugging. : [Attachment 409946] proposed patch.

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 217055: Add Bounds Check Elimination validation for debugging.
https://bugs.webkit.org/show_bug.cgi?id=217055

Attachment 409946: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=409946&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 409946
  --> https://bugs.webkit.org/attachment.cgi?id=409946
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=409946&action=review

r=me with nit

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:-381
> -

Undo please.

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4654
> +	   RELEASE_ASSERT(Options::validateBoundsCheckElimination());

Does this really do anything?