[webkit-reviews] review granted: [Bug 217060] Fullscreen mode on mlb.com shows white letterboxing when video aspect ratio does not match screen : [Attachment 409908] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 28 11:53:18 PDT 2020
Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 217060: Fullscreen mode on mlb.com shows white letterboxing when video
aspect ratio does not match screen
https://bugs.webkit.org/show_bug.cgi?id=217060
Attachment 409908: Patch
https://bugs.webkit.org/attachment.cgi?id=409908&action=review
--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 409908
--> https://bugs.webkit.org/attachment.cgi?id=409908
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=409908&action=review
> Source/WebCore/page/Quirks.cpp:1074
> +bool Quirks::needsBlackFullscreenBackgroundQuirk() const
Frustrating that unlike per-app quirks that at least have "linked on or after"
rules, per-website quirks don’t come with an expiration date or any plan to
eventually remove them. Do we need a comment explaining something about the
context of why the quirk is added to help future people know when to remove a
quirk?
> Source/WebCore/page/Quirks.cpp:1081
> + m_needsBlackFullscreenBackgroundQuirk =
equalLettersIgnoringASCIICase(host, "mlb.com") ||
host.endsWithIgnoringASCIICase(".mlb.com");
I wonder if this "equals or ends with (preceded by dot)" idiom should finally
get its own helper function.
More information about the webkit-reviews
mailing list