[webkit-reviews] review granted: [Bug 217031] Web Inspector: add checkbox to local override popover to allow it to skip the network : [Attachment 409822] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 217031: Web Inspector: add checkbox to local override popover to allow it
to skip the network
https://bugs.webkit.org/show_bug.cgi?id=217031

Attachment 409822: Patch

https://bugs.webkit.org/attachment.cgi?id=409822&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 409822
  --> https://bugs.webkit.org/attachment.cgi?id=409822
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409822&action=review

r=me, looks good overall.

I prefer 'WI.LocalResourceOverride.Type.InterceptRequest' to
InterceptRequestWithResponse. I don't think the 'WithResponse' adds anything.

Also, please investigate mac-wk2 EWS failure.

> Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:961
> +	       base64Encoded: revision.base64Encoded,

Nit: !! would make it more clear this is a bool.

> Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:1479
> +	   if (localResourceOverride.disabled)

Soo nice.

> Source/WebInspectorUI/UserInterface/Models/LocalResourceOverride.js:75
> +	   // COMPATIBILITY (iOS 13.4):
Network.interceptWithRequest/Network.interceptRequestWithResponse did not exist
yet.

Have you tested this patch when inspecting iOS 13.4?