[webkit-reviews] review granted: [Bug 178225] Xcode build should parallelize targets : [Attachment 409641] Part 1: Enable parallel schemes in WebKit.xcworkspace

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 178225: Xcode build should parallelize targets
https://bugs.webkit.org/show_bug.cgi?id=178225

Attachment 409641: Part 1: Enable parallel schemes in WebKit.xcworkspace

https://bugs.webkit.org/attachment.cgi?id=409641&action=review




--- Comment #31 from Darin Adler <darin at apple.com> ---
Comment on attachment 409641
  --> https://bugs.webkit.org/attachment.cgi?id=409641
Part 1: Enable parallel schemes in WebKit.xcworkspace

I suppose the main issue here is that when you specify inputs and outputs we
have to be sure both lists are exhaustive. I wasn’t able to audit each list.
This is a welcome improvement, but will cause subtle failures if we left out
any input or output files.

For example, in steps that execute scripts, we want to list the scripts
themselves *plus anything they invoke, including perl modules as well as perl
scripts and all the python sources*. I’m guessing you did all that carefully,
but I am not sure!