[webkit-reviews] review granted: [Bug 217015] [Preferences] Generate Debug and Internal preferences for WebKitLegacy : [Attachment 409793] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 217015: [Preferences] Generate Debug and Internal preferences for
WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=217015

Attachment 409793: Patch

https://bugs.webkit.org/attachment.cgi?id=409793&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 409793
  --> https://bugs.webkit.org/attachment.cgi?id=409793
Patch

Another step in the right direction. Really need to keep going so we can delete
huge swathes of this code. In particular, need to stop adding code just to
plumb through features we want to test when we have no intention of offering
them to enable/disable as API or SPI. And if we have legacy API and SPI that we
need to keep around, would like this to be a small shim, not a lot of
hand-written code.