[webkit-reviews] review granted: [Bug 217012] [SOUP] WebSocket: cookies set in request don't appear in the inspector : [Attachment 409776] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 217012: [SOUP] WebSocket: cookies set in request don't appear in the
inspector
https://bugs.webkit.org/show_bug.cgi?id=217012

Attachment 409776: Patch

https://bugs.webkit.org/attachment.cgi?id=409776&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 409776
  --> https://bugs.webkit.org/attachment.cgi?id=409776
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409776&action=review

> Source/WebKit/NetworkProcess/soup/WebSocketTaskSoup.cpp:83
> +    g_signal_connect(msg, "starting", G_CALLBACK(+[](SoupMessage* msg,
WebSocketTask* task) {

+[] to convert to vanilla function pointer so we can use it in a signal
callback is amazing... I didn't know this was possible!