[webkit-reviews] review granted: [Bug 217010] [SOUP] Do not set site for cookies twice in case of redirection : [Attachment 409771] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Sep 26 04:47:18 PDT 2020
Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 217010: [SOUP] Do not set site for cookies twice in case of redirection
https://bugs.webkit.org/show_bug.cgi?id=217010
Attachment 409771: Patch
https://bugs.webkit.org/attachment.cgi?id=409771&action=review
--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 409771
--> https://bugs.webkit.org/attachment.cgi?id=409771
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=409771&action=review
> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:115
> + if (!isSameSiteUnspecified()) {
Is it OK for SameSite to ever be unspecified when we send a message? Maybe we
should have an assert to ensure that doesn't happen?
More information about the webkit-reviews
mailing list