[webkit-reviews] review granted: [Bug 151234] visibilitychange:hidden doesn't fire during page navigations : [Attachment 409751] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 151234: visibilitychange:hidden doesn't fire during page navigations
https://bugs.webkit.org/show_bug.cgi?id=151234

Attachment 409751: Patch

https://bugs.webkit.org/attachment.cgi?id=409751&action=review




--- Comment #27 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 409751
  --> https://bugs.webkit.org/attachment.cgi?id=409751
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409751&action=review

> Source/WebCore/loader/FrameLoader.cpp:3284
> +	       m_frame.document()->setHiddenDueToDismissal(true);

This is confusing name. How about setVisibilityHiddenDueToPageDismissal?