[webkit-reviews] review granted: [Bug 216958] WebKitLegacy should call Page::finalizeRenderingUpdate() : [Attachment 409729] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 25 14:51:07 PDT 2020


Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 216958: WebKitLegacy should call Page::finalizeRenderingUpdate()
https://bugs.webkit.org/show_bug.cgi?id=216958

Attachment 409729: Patch

https://bugs.webkit.org/attachment.cgi?id=409729&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 409729
  --> https://bugs.webkit.org/attachment.cgi?id=409729
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409729&action=review

> Source/WebCore/page/Page.cpp:1510
> +		   page->isolatedUpdateRendering();

Hmm. There's not really "isolation" of any sort. It affects the real world. Is
it "out of band"? I don't know what to call it. "updateRenderingWithout..."?


More information about the webkit-reviews mailing list