[webkit-reviews] review granted: [Bug 216041] Move NetworkProcessProxy ownership from WebProcessPool to WebsiteDataStore : [Attachment 409631] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 216041: Move NetworkProcessProxy ownership from WebProcessPool to
WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216041

Attachment 409631: Patch

https://bugs.webkit.org/attachment.cgi?id=409631&action=review




--- Comment #41 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 409631
  --> https://bugs.webkit.org/attachment.cgi?id=409631
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409631&action=review

Too big to critically analyze every single change.

Overall, seems fine.

Yay tests.

One specific review comment.

> Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h:82
> -    bool shouldEnableITPDatabase { false };
> +    bool shouldEnableITPDatabase { true };

Why this change?