[webkit-reviews] review granted: [Bug 149551] [SOUP] Slack.com is not working, new messages do not load due to WebSocket authentication failure issue : [Attachment 409698] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 149551: [SOUP] Slack.com is not working, new messages do not load due to
WebSocket authentication failure issue
https://bugs.webkit.org/show_bug.cgi?id=149551

Attachment 409698: Patch

https://bugs.webkit.org/attachment.cgi?id=409698&action=review




--- Comment #31 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 409698
  --> https://bugs.webkit.org/attachment.cgi?id=409698
Patch

Well... surprise. Any idea why this isn't broken for Safari?

Looking for other suspicious cases,there are a lot of places where we call
setFirstPartyForCookies but not addSameSiteInfoToRequestIfNeeded:
WebKitWebSourceGStreamer.cpp, SWServer.cpp, XSLTProcessor.cpp,
NetworkCacheSpeculativeLoadManager.cpp, NetworkDataTaskCocoa.mm,
NetworkDataTaskSoup.cpp, and WebProcessPool.cpp. I wonder how many of these are
similar bugs and how many are covered by FrameLoader?

I also wonder why cookie_is_valid_for_same_site_policy() isn't causing this
problem? We probably still need to look closer at that....