[webkit-reviews] review granted: [Bug 216976] [LFC][Out-of-flow] ASSERTION FAILED: !layoutBox.isOutOfFlowPositioned() in WebCore::Layout::FormattingContext::Geometry::computedHeightValue : [Attachment 409697] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 25 08:33:05 PDT 2020


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 216976: [LFC][Out-of-flow] ASSERTION FAILED:
!layoutBox.isOutOfFlowPositioned() in
WebCore::Layout::FormattingContext::Geometry::computedHeightValue
https://bugs.webkit.org/show_bug.cgi?id=216976

Attachment 409697: Patch

https://bugs.webkit.org/attachment.cgi?id=409697&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 409697
  --> https://bugs.webkit.org/attachment.cgi?id=409697
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409697&action=review

> Source/WebCore/layout/FormattingContextGeometry.cpp:-1177
> -    // FIXME: Find out if min/max-height properties should also be taken
into account here.

I guess we found out!


More information about the webkit-reviews mailing list