[webkit-reviews] review granted: [Bug 216957] [LFC][IFC] Add helper functions to create LineBox::InlineBox objects for inline level boxes. : [Attachment 409653] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 216957: [LFC][IFC] Add helper functions to create LineBox::InlineBox
objects for inline level boxes.
https://bugs.webkit.org/show_bug.cgi?id=216957

Attachment 409653: Patch

https://bugs.webkit.org/attachment.cgi?id=409653&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 409653
  --> https://bugs.webkit.org/attachment.cgi?id=409653
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409653&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:37
> +    , m_logicalRect({ }, logicalLeft, logicalSize.width(),
logicalSize.height())

Argument order is confusing because	FloatRect(float x, float y, float
width, float height)