[webkit-reviews] review granted: [Bug 216949] Support EXT_float_blend : [Attachment 409637] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted James Darpinian
<jdarpinian at chromium.org>'s request for review:
Bug 216949: Support EXT_float_blend
https://bugs.webkit.org/show_bug.cgi?id=216949

Attachment 409637: Patch

https://bugs.webkit.org/attachment.cgi?id=409637&action=review




--- Comment #4 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 409637
  --> https://bugs.webkit.org/attachment.cgi?id=409637
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409637&action=review

Looks good overall! The bulk of this patch is new conformance suite files which
it looks like were automatically and maybe accidentally imported; please remove
those so that the patch can stay better focused. Thanks.

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp:1485
> +				functions->isAtLeastGLES(gl::Version(3, 2));

Double-checked the ES 3.2 spec, and the reason this is implicitly supported is
that floating-point framebuffers were subsumed into the core ES 3.2 spec
without the restrictions listed in EXT_color_buffer_float. Not sure whether
that's worth a comment.

> Source/WebCore/html/canvas/EXTFloatBlend.cpp:2
> + * Copyright (C) 2014 Apple Inc. All rights reserved.

2020? Here and below.

> LayoutTests/webgl/resources/webgl_test_files/js/desktop-gl-constants.js:1
> +/*

Could you remove the addition of this file? It looks like it's unreferenced.

Actually it looks like many new files were accidentally imported from the
top-of-tree conformance suite. Please remove them to keep this patch better
focused.