[webkit-reviews] review granted: [Bug 216942] REGRESSION(r267379): Web Inspector: Sources navigation sidebar is empty every other time it's selected : [Attachment 409617] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 216942: REGRESSION(r267379): Web Inspector: Sources navigation sidebar is
empty every other time it's selected
https://bugs.webkit.org/show_bug.cgi?id=216942

Attachment 409617: Patch

https://bugs.webkit.org/attachment.cgi?id=409617&action=review




--- Comment #5 from Brian Burg <bburg at apple.com> ---
Comment on attachment 409617
  --> https://bugs.webkit.org/attachment.cgi?id=409617
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409617&action=review

r=me with some copyediting

> Source/WebInspectorUI/UserInterface/Views/Sidebar.js:75
> +	   console.assert(!(sidebarPanel.parentSidebar &&
sidebarPanel.parentSidebar !== this), "sidebarPanel already has a different
parentSidebar", sidebarPanel);

The assertion message seems incorrect, it could assert if
sidebarPanel.parentSidebar is falsy as well.

How about a simpler message "Failed to insert sidebar panel". We'd be able to
infer which condition failed from looking at the `sidebarPanel` argument, so a
more specific message is unnecessary.