[webkit-reviews] review granted: [Bug 216722] WebGL should use GLES in iOS apps running on Apple Silicon : [Attachment 409547] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 216722: WebGL should use GLES in iOS apps running on Apple Silicon
https://bugs.webkit.org/show_bug.cgi?id=216722

Attachment 409547: Patch

https://bugs.webkit.org/attachment.cgi?id=409547&action=review




--- Comment #25 from Tim Horton <thorton at apple.com> ---
Comment on attachment 409547
  --> https://bugs.webkit.org/attachment.cgi?id=409547
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409547&action=review

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm:73
> +    mContext = [[getEAGLContextClass() alloc]
initWithAPI:kEAGLRenderingAPIOpenGLES3];

usually want allocEAGLContextInstance() or you'll get mysterious ambiguous
selector warnings years down the road

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm:355
> +    context		      = [[getEAGLContextClass() alloc]
initWithAPI:kEAGLRenderingAPIOpenGLES3];

here too