[webkit-reviews] review granted: [Bug 216939] Use more inline initialization and constexpr in WebAudio code : [Attachment 409610] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 24 12:24:44 PDT 2020


Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 216939: Use more inline initialization and constexpr in WebAudio code
https://bugs.webkit.org/show_bug.cgi?id=216939

Attachment 409610: Patch

https://bugs.webkit.org/attachment.cgi?id=409610&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 409610
  --> https://bugs.webkit.org/attachment.cgi?id=409610
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409610&action=review

> Source/WebCore/platform/audio/HRTFPanner.h:85
> +    int m_azimuthIndex1 { UninitializedAzimuth };

Maybe these become optionals too?

> Source/WebCore/platform/audio/HRTFPanner.h:89
> +    int m_azimuthIndex2 { UninitializedAzimuth };

Maybe these become optionals too?


More information about the webkit-reviews mailing list