[webkit-reviews] review requested: [Bug 216935] Declare render quantum size constant in AudioUtilities.h : [Attachment 409596] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has asked  for review:
Bug 216935: Declare render quantum size constant in AudioUtilities.h
https://bugs.webkit.org/show_bug.cgi?id=216935

Attachment 409596: Patch

https://bugs.webkit.org/attachment.cgi?id=409596&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 409596
  --> https://bugs.webkit.org/attachment.cgi?id=409596
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409596&action=review

> Source/WebCore/ChangeLog:10
> +	   Declare render quantum size [1] constant in AudioUtilities.h so that
it can be used in both
> +	   platform/ and Modules/webaudio/. Also update the code so that we
have a single constant
> +	   instead of many.

Conceptually, this feels wrong. The intent of platform is to abstract away
differences between different platforms base libraries. Having it know about a
web platform concept like a specific "render quantum size" seems like a
violation of that.