[webkit-reviews] review granted: [Bug 216934] CrashTracer: com.apple.WebKit.Networking in NetworkSession::firstPartyHostCNAMEDomain() code : [Attachment 409593] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 24 10:40:49 PDT 2020


Alex Christensen <achristensen at apple.com> has granted
katherine_cheney at apple.com's request for review:
Bug 216934: CrashTracer: com.apple.WebKit.Networking in
NetworkSession::firstPartyHostCNAMEDomain() code
https://bugs.webkit.org/show_bug.cgi?id=216934

Attachment 409593: Patch

https://bugs.webkit.org/attachment.cgi?id=409593&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 409593
  --> https://bugs.webkit.org/attachment.cgi?id=409593
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409593&action=review

> Source/WebKit/NetworkProcess/NetworkSession.cpp:300
> +    if (firstPartyHost.isNull())

Alternatively you could use decltype(m_firstPartyHostCNAMEDomains)::isValidKey


More information about the webkit-reviews mailing list