[webkit-reviews] review denied: [Bug 216630] Integrate meterElementShadow.css into html.css : [Attachment 408974] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 24 10:29:29 PDT 2020
Antti Koivisto <koivisto at iki.fi> has denied review:
Bug 216630: Integrate meterElementShadow.css into html.css
https://bugs.webkit.org/show_bug.cgi?id=216630
Attachment 408974: Patch
https://bugs.webkit.org/attachment.cgi?id=408974&action=review
--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 408974
--> https://bugs.webkit.org/attachment.cgi?id=408974
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=408974&action=review
> Source/WebCore/html/HTMLMeterElement.cpp:-232
> - auto style = HTMLStyleElement::create(HTMLNames::styleTag, document(),
false);
> - style->setTextContent(shadowStyle);
> - root.appendChild(style);
Why you want to undo the use of scoped style and put these things to the global
stylesheet? You are essentially reverting
https://bugs.webkit.org/show_bug.cgi?id=163212
More information about the webkit-reviews
mailing list