[webkit-reviews] review denied: [Bug 215379] Implement HTTPServer for API tests in c++ : [Attachment 409506] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Takashi Komori
<takashi.komori at sony.com>'s request for review:
Bug 215379: Implement HTTPServer for API tests in c++
https://bugs.webkit.org/show_bug.cgi?id=215379

Attachment 409506: Patch

https://bugs.webkit.org/attachment.cgi?id=409506&action=review




--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 409506
  --> https://bugs.webkit.org/attachment.cgi?id=409506
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409506&action=review

This is a little better in that it doesn't directly use TCPServer, but it's
still not a well-abstracted multi-platform server.  I was thinking something
like this:

class Connection {
    ...
private:
#if PLATFORM(COCOA)
    RetainPtr<nw_connection_t> m_connection;
#else
    int socket { 0 };
    uint16_t m_port { 0 };
    std::unique_ptr<SSL, deleter<SSL>> m_ssl;
#endif
};

etc.

> Tools/TestWebKitAPI/HTTPServerPOSIX.h:68
> +struct HTTPServerPOSIX::HTTPResponse {

This is an entirely duplicate class.  We should move things around to reuse the
same class.