[webkit-reviews] review granted: [Bug 216822] [GTK][WPE] Move TLS errors API from WebKitContext to WebKitWebsiteDataManager : [Attachment 409358] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 216822: [GTK][WPE] Move TLS errors API from WebKitContext to
WebKitWebsiteDataManager
https://bugs.webkit.org/show_bug.cgi?id=216822

Attachment 409358: Patch

https://bugs.webkit.org/attachment.cgi?id=409358&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 409358
  --> https://bugs.webkit.org/attachment.cgi?id=409358
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409358&action=review

> Source/WebCore/platform/network/soup/SoupNetworkSession.h:82
> +    bool m_ignoreTLSErrors { false };

You may want to have this be consistent with its default value on
WebsiteDataStore.
You may also want to have the default be false, but it was true on
WebProcessPool so this is maintaining the status quo.