[webkit-reviews] review granted: [Bug 216752] [LFC Display] Add the beginnings of a CSS display box hierarchy and CSS painter : [Attachment 409501] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 216752: [LFC Display] Add the beginnings of a CSS display box hierarchy and
CSS painter
https://bugs.webkit.org/show_bug.cgi?id=216752

Attachment 409501: Patch

https://bugs.webkit.org/attachment.cgi?id=409501&action=review




--- Comment #6 from zalan <zalan at apple.com> ---
Comment on attachment 409501
  --> https://bugs.webkit.org/attachment.cgi?id=409501
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409501&action=review

> Source/WebCore/ChangeLog:105
> +2020-09-20  Simon Fraser  <simon.fraser at apple.com>
> +

double changelog.

> Source/WebCore/display/DisplayLayerController.cpp:82
> +    if (!m_displayTree)
>	   return;

when is it nullptr?

> Source/WebCore/display/DisplayTreeBuilder.cpp:56
> +    if (!layoutState.hasRoot())
> +	   return nullptr;

shouldn't this be an assert instead? -enforcing the caller to only build
display tree on a valid layout state?

> Source/WebCore/display/DisplayTreeBuilder.h:58
> +    float m_pixelSnappingFactor;

float m_pixelSnappingFactor { 1 }; ?

> Source/WebCore/display/DisplayView.cpp:91
> +    return page() ? page()->deviceScaleFactor() : 1.0f;

Modern display tree should have a fallback value of 2 device pixels per css
pixel. (j/k)