[webkit-reviews] review granted: [Bug 209461] [css-grid] Grid layout unstable with percentage margin : [Attachment 409485] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Oriol Brufau
<obrufau at igalia.com>'s request for review:
Bug 209461: [css-grid] Grid layout unstable with percentage margin
https://bugs.webkit.org/show_bug.cgi?id=209461

Attachment 409485: Patch

https://bugs.webkit.org/attachment.cgi?id=409485&action=review




--- Comment #13 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 409485
  --> https://bugs.webkit.org/attachment.cgi?id=409485
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409485&action=review

r=me

Let's hope this time we don't get new regressions. :-)

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:115
> +static bool hasRelativeOrIntrinsicSizeForChild(const RenderBox& child,
GridTrackSizingDirection direction)

Nit: Missing new line before method name.