[webkit-reviews] review granted: [Bug 216760] [JSC] Intl spec update: handle awkward rounding behavior : [Attachment 409494] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 216760: [JSC] Intl spec update: handle awkward rounding behavior
https://bugs.webkit.org/show_bug.cgi?id=216760

Attachment 409494: Patch

https://bugs.webkit.org/attachment.cgi?id=409494&action=review




--- Comment #5 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 409494
  --> https://bugs.webkit.org/attachment.cgi?id=409494
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409494&action=review

r=me, based on the understanding that test262 will be fixed soon.

> JSTests/stress/intl-numberformat.js:464
> +    let nf = new Intl.NumberFormat('en', {

I'd be inclined to ask for a test using a different locale but I guess this
issue is more about options than locale anyway.