[webkit-reviews] review granted: [Bug 208752] [Media in GPU Process] Implement caption support in video fullscreen and PiP : [Attachment 409420] Fix build failures again

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 23 11:00:59 PDT 2020


Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 208752: [Media in GPU Process] Implement caption support in video
fullscreen and PiP
https://bugs.webkit.org/show_bug.cgi?id=208752

Attachment 409420: Fix build failures again

https://bugs.webkit.org/attachment.cgi?id=409420&action=review




--- Comment #8 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 409420
  --> https://bugs.webkit.org/attachment.cgi?id=409420
Fix build failures again

View in context: https://bugs.webkit.org/attachment.cgi?id=409420&action=review

> Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:154
> +#if PLATFORM(IOS_FAMILY)
> +    if (decoder.messageReceiverName() ==
Messages::RemoteMediaSessionHelper::messageReceiverName()) {
> +	   // FIXME
> +	   return true;
> +    }
> +#endif

It might make more sense to add this when we fix RemoteMediaSessionHelper.


More information about the webkit-reviews mailing list