[webkit-reviews] review denied: [Bug 216872] Introduce WKWebViewConfiguration mediaDevicesEnabled : [Attachment 409465] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied youenn fablet
<youennf at gmail.com>'s request for review:
Bug 216872: Introduce WKWebViewConfiguration mediaDevicesEnabled
https://bugs.webkit.org/show_bug.cgi?id=216872

Attachment 409465: Patch

https://bugs.webkit.org/attachment.cgi?id=409465&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 409465
  --> https://bugs.webkit.org/attachment.cgi?id=409465
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409465&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:172
> +    BOOL _mediaDevicesEnabled;

This should go on API::PageConfiguration instead.

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:123
> + at property (nonatomic, setter=_setMediaDevicesEnabled:) BOOL
_mediaDevicesEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

Could you deprecate the preference SPI with this as a replacement?