[webkit-reviews] review granted: [Bug 216866] [LFC][Floats] Remove the redundant RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled() check from FloatingState::append : [Attachment 409446] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 22 20:02:54 PDT 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 216866: [LFC][Floats] Remove the redundant
RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled() check from
FloatingState::append
https://bugs.webkit.org/show_bug.cgi?id=216866

Attachment 409446: Patch

https://bugs.webkit.org/attachment.cgi?id=409446&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 409446
  --> https://bugs.webkit.org/attachment.cgi?id=409446
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409446&action=review

> Source/WebCore/layout/floats/FloatingState.cpp:68
> +    ASSERT(!floatItem.floatBox() || m_floats.findMatching([&] (auto& entry)
{

ASSERT_IMPLIES(floatItem.floatBox(), ....) ?


More information about the webkit-reviews mailing list