[webkit-reviews] review granted: [Bug 216806] Refactor build rules in Makefiles and Makefile.shared : [Attachment 409329] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Keith Rollin
<krollin at apple.com>'s request for review:
Bug 216806: Refactor build rules in Makefiles and Makefile.shared
https://bugs.webkit.org/show_bug.cgi?id=216806

Attachment 409329: Patch

https://bugs.webkit.org/attachment.cgi?id=409329&action=review




--- Comment #4 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 409329
  --> https://bugs.webkit.org/attachment.cgi?id=409329
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409329&action=review

r=me

> Source/Makefile:22
> +	@$(build_target_for_each_module)

This doesn't need to be @$(call build_target_for_each_module) as done in
Makefile.shared?  Is that because we don't need to pass arguments?

> Makefile.shared:101
> +		[[ -t 1 ]] && COLOR_DIAGNOSTICS_ARG="COLOR_DIAGNOSTICS=YES"; \

I'm sorry, what does `[[ -t 1 ]]` do?!

> Makefile.shared:123
> +	@$(call set_webkit_configuration,--debug --force-optimization-level=O3)

This won't pass `--debug --force-optimization-level=O3` as a single string to
the shell, will it?