[webkit-reviews] review granted: [Bug 216756] Selection API: A few more refinements to DOMSelection and VisibleSelection to pass all WPT tests : [Attachment 409259] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 216756: Selection API: A few more refinements to DOMSelection and
VisibleSelection to pass all WPT tests
https://bugs.webkit.org/show_bug.cgi?id=216756

Attachment 409259: Patch

https://bugs.webkit.org/attachment.cgi?id=409259&action=review




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 409259
  --> https://bugs.webkit.org/attachment.cgi?id=409259
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409259&action=review

> Source/WebCore/editing/VisibleSelection.h:160
> +    bool m_anchorIsFirst : 1; // True if the anchor is before the focus.
> +    bool m_isDirectional : 1; // On Mac, Shift-arrow keys move the anchor in
a directional selection and moves either end to always extend in a
non-directional selection.

This is a bit tangential but it seems totally unnecessary to use bitfields
here.