[webkit-reviews] review granted: [Bug 215829] [ iOS Release ] imported/w3c/web-platform-tests/* is flaky failing 200+ tests : [Attachment 409127] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 21 06:34:13 PDT 2020


youenn fablet <youennf at gmail.com> has granted Sam Sneddon [:gsnedders]
<gsnedders at apple.com>'s request for review:
Bug 215829: [ iOS Release ] imported/w3c/web-platform-tests/* is flaky failing
200+ tests
https://bugs.webkit.org/show_bug.cgi?id=215829

Attachment 409127: Patch

https://bugs.webkit.org/attachment.cgi?id=409127&action=review




--- Comment #31 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 409127
  --> https://bugs.webkit.org/attachment.cgi?id=409127
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409127&action=review

> LayoutTests/imported/w3c/ChangeLog:9
> +	   (ServerProc.create_daemon):

As per our direct discussion, please add more comments explaining the default
value on various platforms, and the value you are selecting here.

> LayoutTests/imported/w3c/web-platform-tests/tools/serve/serve.py:421
> +	   if sys.platform == "darwin":

Maybe we should verify that for any given system, we have a large enough value.


More information about the webkit-reviews mailing list