[webkit-reviews] review denied: [Bug 216696] Add support for HTMLMediaElement.setSinkId : [Attachment 409274] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 21 08:28:20 PDT 2020


Sam Weinig <sam at webkit.org> has denied youenn fablet <youennf at gmail.com>'s
request for review:
Bug 216696: Add support for HTMLMediaElement.setSinkId
https://bugs.webkit.org/show_bug.cgi?id=216696

Attachment 409274: Patch

https://bugs.webkit.org/attachment.cgi?id=409274&action=review




--- Comment #12 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 409274
  --> https://bugs.webkit.org/attachment.cgi?id=409274
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409274&action=review

> Source/WebCore/ChangeLog:9
> +	   Introduce a setting to expose these methods and to enable/disable
user gesture requirement.

How can we test the user gesture requirement? It seems like that's something we
wouldn't want to break.


More information about the webkit-reviews mailing list