[webkit-reviews] review granted: [Bug 216764] [JSC] Proxy should be trapped if base value is primitive : [Attachment 409264] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 21 09:49:39 PDT 2020


Darin Adler <darin at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 216764: [JSC] Proxy should be trapped if base value is primitive
https://bugs.webkit.org/show_bug.cgi?id=216764

Attachment 409264: Patch

https://bugs.webkit.org/attachment.cgi?id=409264&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 409264
  --> https://bugs.webkit.org/attachment.cgi?id=409264
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409264&action=review

> Source/JavaScriptCore/runtime/JSCJSValue.cpp:188
> +		   ProxyObject* proxy = jsCast<ProxyObject*>(obj);

auto to avoid repeating the same type name twice?


More information about the webkit-reviews mailing list