[webkit-reviews] review granted: [Bug 216742] [LFC][IFC] InlineFormattingState should not store display lines and runs : [Attachment 409233] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 216742: [LFC][IFC] InlineFormattingState should not store display lines and
runs
https://bugs.webkit.org/show_bug.cgi?id=216742

Attachment 409233: Patch

https://bugs.webkit.org/attachment.cgi?id=409233&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 409233
  --> https://bugs.webkit.org/attachment.cgi?id=409233
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409233&action=review

> Source/WebCore/ChangeLog:15
> +	   In this patch,
> +	   1. Display related structures are completely moved out from Layout
namespace
> +	     - InlineFormattingContext does not generate display structures.
> +	     - InlineFormattingState only stores layout data.
> +	     - Layout tree verification works on layout geometry.
> +	     - Layout structures do not embed Display types.
> +	   2. LayoutIntegration creates and maintains the required Display
structures for painting and hittesting.
> +	   3. Display::Run does not use Layout types (InlineLayoutRect,
InlineLayoutUnit).

Nice!