[webkit-reviews] review granted: [Bug 216713] [WebGPU] Add ENABLE(WHLSL_COMPILER) guard : [Attachment 409164] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 18 13:27:02 PDT 2020


Myles C. Maxfield <mmaxfield at apple.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 216713: [WebGPU] Add ENABLE(WHLSL_COMPILER) guard
https://bugs.webkit.org/show_bug.cgi?id=216713

Attachment 409164: Patch

https://bugs.webkit.org/attachment.cgi?id=409164&action=review




--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 409164
  --> https://bugs.webkit.org/attachment.cgi?id=409164
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409164&action=review

> Source/WTF/wtf/PlatformEnableCocoa.h:564
> +#define ENABLE_WEBGPU 0

This shouldn't be unnecessary. The ENABLE() macro yields false if the token
isn't defined.


More information about the webkit-reviews mailing list